[EUWE] Merge pull request #12005 from yrudman/raise-event-when-failover #12332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raise event when failover successful (cherry picked from commit 991855a)
|
Checked commit yrudman@05a44b3 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
|
So, we no longer need the changes to the conflicted file? Can you give some detail around how that worked out? Was there a separate change that made the edit unnecessary? |
|
There is work in progress (from UI team) to replace |
yrudman
deleted the
resolve-conflict-on-backporting-raise-server-event
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raise event when failover successful
(cherry picked from commit 991855a)
Original PR: #12005
There was cherry-pick conflict on backporting changes for
app/decorators/miq_event_definition_decorator.rbwhich was resolved in this PR