Fix Orchestration Stack UI for infra stacks #12569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sseago
force-pushed
the
orchestration-stacks-infra
branch
2 times, most recently
from
5b01123
to
008bf26
Compare
|
@lgalis Ready for you to test. |
|
@sseago - looks good. Can you add a spec? |
|
@lgalis So I guess I'll add tests for the following to orchestration_stack_controller_spec.rb:
|
|
@sseago - perfect, thanks! |
https://bugzilla.redhat.com/show_bug.cgi?id=1383263 Prior development work ended up breaking infra stack UI when separating Configuration jobs from Cloud Orchestration Stacks. This is a short-term fix which removes the explicit Infra model class limitation and filters Configuration jobs out of the show_list operation. Longer-term, we need to refactor this into separate controllers for infra and cloud stacks.
sseago
force-pushed
the
orchestration-stacks-infra
branch
from
008bf26
to
664acf1
Compare
|
Checked commit sseago@664acf1 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
|
@lgalis Spec tests added |
|
@sseago - looks good, thanks! |
|
@dclarizio - would you be able to merge this? |
chessbyte
pushed a commit
that referenced
this pull request
Nov 14, 2016
Fix Orchestration Stack UI for infra stacks (cherry picked from commit f0c0d28) https://bugzilla.redhat.com/show_bug.cgi?id=1394842
|
Euwe Backport details: $ git log -1
commit 9d1fefb02f88d3b113fe593f71b8c44345bb1547
Author: Dan Clarizio <dclarizi@redhat.com>
Date: Fri Nov 11 16:01:21 2016 -0800
Merge pull request #12569 from sseago/orchestration-stacks-infra
Fix Orchestration Stack UI for infra stacks
(cherry picked from commit f0c0d28b3662e317d691f5de5f0d379d65fd69d1)
https://bugzilla.redhat.com/show_bug.cgi?id=1394842 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1383263
Prior development work ended up breaking infra stack UI when separating
Configuration jobs from Cloud Orchestration Stacks. This is a
short-term fix which removes the explicit Infra model class limitation
and filters Configuration jobs out of the show_list operation.
Longer-term, we need to refactor this into separate controllers
for infra and cloud stacks.