Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OpenStack node power operations #12601

Merged
merged 1 commit into from
Nov 14, 2016

Conversation

rwsu
Copy link
Contributor

@rwsu rwsu commented Nov 12, 2016

Power operations fails if a node is in "active" provision state.
When active, the node's name includes additional text describing
its role. When name is used as the uuid for Ironic, it causes
issues because the additional text isn't part of the uuid.

The solution is to use uid_ems which is the Ironic uuid.

https://bugzilla.redhat.com/show_bug.cgi?id=1394429

Power operations fails if a node is in "active" provision state.
When active, the node's name includes additional text describing
its role. When name is used as the uuid for Ironic, it causes
issues because the additional text isn't part of the uuid.

The solution is to use uid_ems which is the Ironic uuid.
@miq-bot
Copy link
Member

miq-bot commented Nov 12, 2016

Checked commit rwsu@41ad994 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
1 file checked, 0 offenses detected
Everything looks good. 🍪

@tzumainn
Copy link
Contributor

@miq-bot add_label euwe/yes
@miq-bot add_label blocker
@miq-bot add_label bug

@tzumainn
Copy link
Contributor

👍 tested this, looks good!

@agrare
Copy link
Member

agrare commented Nov 14, 2016

LGTM

@agrare agrare merged commit 762be25 into ManageIQ:master Nov 14, 2016
@agrare agrare added this to the Sprint 49 Ending Nov 14, 2016 milestone Nov 14, 2016
@agrare agrare self-assigned this Nov 14, 2016
chessbyte pushed a commit that referenced this pull request Nov 14, 2016
@chessbyte
Copy link
Member

Euwe Backport details:

$ git log -1
commit ee8d7afdf91071633a2741ea0276256331ed4389
Author: Adam Grare <agrare@redhat.com>
Date:   Mon Nov 14 13:03:06 2016 -0500

    Merge pull request #12601 from rwsu/node-power-on-off-uid-fix

    Fix OpenStack node power operations
    (cherry picked from commit 762be2540fb6e8bb73f5f5b618becb5164652868)

    https://bugzilla.redhat.com/show_bug.cgi?id=1394429

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants