Check ems_cluster_id - OS Infra SSH KEY validation #13275
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds ems_cluster_id checking when selecting Hosts for ssh key validation on OpenStack Infra Provider. Adds few comments to that part of validation code to clarify its intent. Solves https://bugzilla.redhat.com/show_bug.cgi?id=1406443
|
Checked commit petrblaho@cd052ce with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
|
Makes sense to me, a non-deployed host could be in any state with anything on it, so checking it seems like a bad idea. |
|
👍 |
|
@miq-bot assign @blomquisg |
|
@petrblaho looks like you and @mansam are solving a related problem. See #13159. I mean, it looks like they're slightly different issues. Same thing here ... would be good to see a test exercise this. Should you and @mansam should consolidate these fixes? Or, should they stay separate? |
|
Code from this PR is included in #13445 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds ems_cluster_id checking when selecting Hosts for ssh key
validation on OpenStack Infra Provider.
Adds few comments to that part of validation code to clarify its intent.
Solves
https://bugzilla.redhat.com/show_bug.cgi?id=1406443