[EUWE] Chargebacks for SCVMM (rollup-less) #13419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are three possible callers of build_results_for_report_chargeback each of them sets @options to the same value that is later passed in as an argument. Let's have a single place to set it. In future I want to get a rid of class variable. But it will take few moments before we get there. (cherry picked from commit 52a00de)
This was used for Ad-hoc chargeback schedule. It is unused since 2010 (a59b87cf535fd464d56d145bac12873cff65ea7d). (cherry picked from commit 60554db)
This was never actual option. Only a design idea that never come to be implemented. Let's drop this from documentation now, so we can consolidate the options more. (cherry picked from commit 2c83677)
This will allow us to encapsulate code manipulating it here. (cherry picked from commit 2b7e9f4)
Timezone depends solely on Chargeback/ReportOptions. (cherry picked from commit 7e72957)
(cherry picked from commit e0ecace)
The chargeback's timerange depends only on Chargeback report options. (cherry picked from commit f5df793)
It is only dependent on ReportOptions and shall be part of it. (cherry picked from commit edb6431)
(cherry picked from commit 9cb4026)
(cherry picked from commit 059c92a)
(cherry picked from commit 473d14c)
(cherry picked from commit 814718d)
(cherry picked from commit f068bd8)
(cherry picked from commit d1564db)
Do instanciate early in the calculation process. This will allows us to encapsulate code to these instances. (cherry picked from commit 4ba9459)
(cherry picked from commit 527712d)
It only manipulates Chargeback instance based on perf record. (cherry picked from commit 6c980f0)
(cherry picked from commit 94ae8bc)
This lowers the indirection and complexity. (cherry picked from commit e31d499)
As we see, it takes a very long name to describe what it does. Perhaps we can lower the complexity in future. (cherry picked from commit bc575d3)
As it better describes what it does. It calculates hourly cost for a given metric. (cherry picked from commit 16d00c3)
(cherry picked from commit b938855)
(cherry picked from commit 6c172d9)
This will be needed once we will have ChargebackRateDetails with dynamic rate/metric names. (cherry picked from commit 9492963)
Not all the rates are relevant to the given chargeback. At this moment, the field is calculated only if the given chargeback type is able to carry on the result. In future, we may be able to calculate only those fields/columns needed by user. Then this method will come in handy. Using word fields vs. columns as it is common more common in the chargeback's codebase now. (cherry picked from commit 631a8ca)
(cherry picked from commit d714d67)
(cherry picked from commit 4588c62)
This will help us to dispart Chargeback calculations and rates cache. (cherry picked from commit 07cd0ff) Conflicts: app/models/chargeback.rb app/models/chargeback_container_image.rb
|
Checked commits isimluk/manageiq@fc542ae~...44aa15b with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 app/models/chargeback/consumption_history.rb
app/models/chargeback/report_options.rb
app/models/chargeback_container_image.rb
app/models/chargeback_vm.rb
app/models/metric/chargeback_helper.rb
|
isimluk
changed the title
|
@isimluk unrecognized command 'remove', ignoring... Accepted commands are: add_label, remove_label, rm_label, assign, set_milestone |
|
@miq-bot remove_label wip |
This was referenced Jan 11, 2017
lpichler
approved these changes
Jan 13, 2017
|
@simaishi This one is good to merge. |
This was referenced Jan 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is equivalent of backporting the following prs and resolving conflicts.
#12049
#11925
#12616
#12610
#12608
#12792
#12914
#12670
#13221
#13229
#13269
Notes
@miq-bot add_label wip