Don't send 'next_run=false' to oVirt 3.6 #13677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jhernand tests fails due to the change. |
In oVirt virtual machines have two sets of settings: the settings used
by the current running virtual machine, and the settings that will be
used the next time the virtual machine is started. To select which one
to update it is necessary to use the 'next_run' parameter. For example,
to update the memory that will be used the next time is started the
API request should be like this:
PUT /ovirt-engine/api/vms/{vm:id};next_run=true
The value 'false' should tell the server to update the current running
configuration. But in version 3.6 of oVirt it is just ignored, the mere
presence of the 'next_run' parameter is interpreted as a request to
modify the next start settings, regardless of its value.
Currently the oVirt provider uses 'next_run=false' explicitly, and as a
result it fails to update the current settings. This patch changes the
provider so that it doesn't send the 'next_run' parameter when its value
is 'false'.
https://bugzilla.redhat.com/1356468
|
@masayag you are right, I forgot to update the tests. It should be fixed now. |
|
Checked commit https://github.com/jhernand/manageiq/commit/21d820eac6c929f8c552776649b072cbaadbe2f6 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@durandom can you review/merge? |
masayag
approved these changes
Jan 30, 2017
durandom
approved these changes
Feb 2, 2017
| @@ -157,7 +157,7 @@ def update_vm_memory(vm, virtual) | |||
| state = vm.attributes.fetch_path(:status, :state) | |||
| if state == 'up' | |||
| vm.update_memory(virtual, guaranteed, :next_run => true) | |||
| vm.update_memory(virtual, nil, :next_run => false) | |||
| vm.update_memory(virtual, nil) | |||
There was a problem hiding this comment.
@jhernand does it make sense to toggle on ovirt versions +3.6? Or are we assuming the absence of this will always be next_run => false ?
There was a problem hiding this comment.
next_run=false is the default in all versions of oVirt, so there is no need to toggle.
simaishi
pushed a commit
that referenced
this pull request
Feb 2, 2017
…_ovirt Don't send 'next_run=false' to oVirt 3.6 (cherry picked from commit 7194f99) https://bugzilla.redhat.com/show_bug.cgi?id=1404316
|
Euwe backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In oVirt virtual machines have two sets of settings: the settings used
by the current running virtual machine, and the settings that will be
used the next time the virtual machine is started. To select which one
to update it is necessary to use the 'next_run' parameter. For example,
to update the memory that will be used the next time is started the
API request should be like this:
PUT /ovirt-engine/api/vms/{vm:id};next_run=true
The value 'false' should tell the server to update the current running
configuration. But in version 3.6 of oVirt it is just ignored, the mere
presence of the 'next_run' parameter is interpreted as a request to
modify the next start settings, regardless of its value.
Currently the oVirt provider uses 'next_run=false' explicitly, and as a
result it fails to update the current settings. This patch changes the
provider so that it doesn't send the 'next_run' parameter when its value
is 'false'.
https://bugzilla.redhat.com/1356468