Add index route for arbitrary resource path collections #13759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imtayadeway
force-pushed
the
api/index-for-arps
branch
from
b0b1947
to
e710afa
Compare
imtayadeway
force-pushed
the
api/index-for-arps
branch
from
e710afa
to
d065f1e
Compare
abellotti
reviewed
Feb 15, 2017
| end | ||
|
|
||
| def ae_browser | ||
| @ae_browser ||= MiqAeBrowser.new(User.current_user) |
There was a problem hiding this comment.
I woudn't memoize this. Recreate it with each request (User.current_user may be different).
There was a problem hiding this comment.
It's not memoized across requests - each request is a new instance
abellotti
reviewed
Feb 15, 2017
| render_resource :settings, ::Settings.to_hash.slice(*Array(selected_sections).collect(&:to_sym)) | ||
| def show | ||
| raise NotFoundError, "Settings category #{@req.c_id} not found" unless exposed_settings.include?(@req.c_id) | ||
| render_resource :settings, ::Settings.to_hash.slice(*Array(@req.c_id).collect(&:to_sym)) |
There was a problem hiding this comment.
Duplicated logic with line 4 for ::Settings.to_hash.... maybe a common method.
|
Checked commits imtayadeway/manageiq@d065f1e~...0d86284 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
Thanks @imtayadeway for the update, will merge when 🍏 |
|
LGTM!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps simplify the
SettingsControllerby removing a conditional. The benefit toAutomateControlleris less tangible, but I do like that it encouraged smaller methods and code reuse, while making things more consistent and "Rails-y"@miq-bot add-label api, refactoring
@miq-bot assign @abellotti