Fix load balancers access in API #13866
Conversation
|
Checked commits imtayadeway/manageiq@6415748~...91535c5 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
| :load_balancers_subcollection_actions: | ||
| :get: | ||
| - :name: show | ||
| :identifier: load_balancer_show |
There was a problem hiding this comment.
why moving these out of here ? keeping them here gives us finer granularity on sub*/roles based on collection.
There was a problem hiding this comment.
We don't need that granularity right now - the identifiers are the same and based on load balancers, not the parent collection. If that changes they can always be broken out again - but I saw an opportunity to consolidate and simplify here.
There was a problem hiding this comment.
ok, so I take it the portion of the PR fixing the bug was adding the subresource_actions get/read role ?
There was a problem hiding this comment.
@abellotti yep, I added the refactoring as a separate commit last in 91535c5
|
🎶 LGTM!! |
Fixes load balancer subcollection member read access.
@miq-bot add-label api, bug
@miq-bot assign @abellotti