Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Alert Definitions (MiqAlert) bulk edits support #14397

Merged
merged 1 commit into from
Mar 20, 2017
Merged

Add Alert Definitions (MiqAlert) bulk edits support #14397

merged 1 commit into from
Mar 20, 2017

Conversation

dkorn
Copy link
Contributor

@dkorn dkorn commented Mar 19, 2017

No description provided.

@dkorn
Copy link
Contributor Author

dkorn commented Mar 19, 2017 •
edited
Loading

@miq-bot add_label enhancement, api, control

@dkorn
Copy link
Contributor Author

dkorn commented Mar 19, 2017

@abellotti @simon3z please review

@dkorn dkorn mentioned this pull request Mar 19, 2017
Merged
@miq-bot
Copy link
Member

miq-bot commented Mar 20, 2017

Checked commit dkorn@511f2d1 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. 👍

@abellotti
Copy link
Member

Thanks @dkorn for making this enhancement, 🙇

@simon3z this can be merged.

simon3z
simon3z approved these changes Mar 20, 2017
View reviewed changes
Copy link
Contributor

@simon3z simon3z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@miq-bot assign abellotti

@abellotti abellotti assigned abellotti and unassigned simon3z Mar 20, 2017
@abellotti abellotti merged commit 111670b into ManageIQ:master Mar 20, 2017
@abellotti abellotti added this to the Sprint 57 Ending Mar 27, 2017 milestone Mar 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon3z simon3z simon3z approved these changes

Assignees

@abellotti abellotti

Labels
api core/policy enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dkorn @miq-bot @abellotti @simon3z @chessbyte