Restrict ServiceOrder deep_copy to non-cart states #14564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jntullo unrecognized command 'bug', ignoring... Accepted commands are: add_label, assign, close_issue, move_issue, remove_label, rm_label, set_milestone |
|
@miq-bot add_label bug, services |
|
Checked commit jntullo@aaeb1de with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
Hey I really like this pr, like REALLY really like ;-) |
|
@jntullo Please label |
|
@miq-bot add_label fine/yes |
simaishi
pushed a commit
that referenced
this pull request
Mar 30, 2017
Restrict ServiceOrder deep_copy to non-cart states (cherry picked from commit 5ce005b)
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copying a ServiceOrder should be restricted to those that are not in the cart for the purpose of it becoming a new cart that can be ordered.
@miq-bot bug, services
cc: @AllenBW @imtayadeway