Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated copyright year for ‘About’ modal #14619

Merged
merged 1 commit into from
Apr 4, 2017
Merged

Updated copyright year for ‘About’ modal #14619

merged 1 commit into from
Apr 4, 2017

Conversation

epwinchell
Copy link
Contributor

@miq-bot
Copy link
Member

miq-bot commented Apr 3, 2017

@epwinchell unrecognized command 'bug', ignoring...

Accepted commands are: add_label, assign, close_issue, move_issue, remove_label, rm_label, set_milestone

@epwinchell
Copy link
Contributor Author

@miq-bot add_label bug, fine/yes

@epwinchell
Copy link
Contributor Author

@miq-bot assign @Fryguy

bdunne
bdunne requested changes Apr 3, 2017
View reviewed changes
Copy link
Member

@bdunne bdunne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@epwinchell Since you're updating the copyright, can you also update LICENSE.txt?

isimluk
isimluk reviewed Apr 4, 2017
View reviewed changes
Copy link
Member

@isimluk isimluk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about locale/zh_CN.yml ?

@miq-bot
Copy link
Member

miq-bot commented Apr 4, 2017

Checked commit https://github.com/epwinchell/manageiq/commit/7aef5acde82ffc8fa5b3f6bd5c40bbb1b4e54093 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks good. 🍰

@epwinchell
Copy link
Contributor Author

@bdunne @isimluk Updated

@isimluk isimluk requested a review from mzazrivec April 4, 2017 14:48
@bdunne bdunne merged commit 9ef53d9 into ManageIQ:master Apr 4, 2017
@bdunne bdunne added this to the Sprint 58 Ending Apr 10, 2017 milestone Apr 4, 2017
simaishi pushed a commit that referenced this pull request Apr 5, 2017
@bdunne @simaishi
Merge pull request #14619 from epwinchell/copyright_update
ef0f3aa 
Updated copyright year for ‘About’ modal
(cherry picked from commit 9ef53d9)
@simaishi
Copy link
Contributor

simaishi commented Apr 5, 2017

Fine backport details:

$ git log -1
commit ef0f3aa2a443b0b768c3dc6e825ccc5e9c28953b
Author: Brandon Dunne <brandondunne@hotmail.com>
Date:   Tue Apr 4 11:16:04 2017 -0400

    Merge pull request #14619 from epwinchell/copyright_update
    
    Updated copyright year for ‘About’ modal
    (cherry picked from commit 9ef53d9e8aff0b21aac5fd58fded5262729bb49d)

@epwinchell epwinchell deleted the copyright_update branch March 20, 2019 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isimluk isimluk isimluk left review comments

@bdunne bdunne bdunne approved these changes

@mzazrivec mzazrivec mzazrivec approved these changes

Assignees

@Fryguy Fryguy

Labels
bug fine/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@epwinchell @miq-bot @simaishi @bdunne @mzazrivec @isimluk @Fryguy