Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch Ansible job plays from job events. #14779

Merged
merged 2 commits into from Apr 18, 2017
Merged

Fetch Ansible job plays from job events. #14779

merged 2 commits into from Apr 18, 2017

Conversation

bzwei
Copy link
Contributor

@bzwei bzwei commented Apr 17, 2017

Starting from AnsibleTower 3.1, there is no longer a dedicated end point for job plays. Instead they need to be fetched by filtering job events.

ansible/ansible_tower_client_ruby#85 already enhance the job class to list all job events. This PR updates the Gemfile to the latest ansible_tower_client and fetches job events in the new way.

Links [Optional]

@bzwei
Copy link
Contributor Author

bzwei commented Apr 17, 2017

@miq-bot add_label bug, providers/ansible_tower, services, fine/yes
@miq-bot assign @gmcculloug

@miq-bot
Copy link
Member

miq-bot commented Apr 17, 2017

Checked commits bzwei/manageiq@eaae992~...e4dcf45 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
4 files checked, 0 offenses detected
Everything looks good. 👍

gmcculloug
gmcculloug approved these changes Apr 17, 2017
View reviewed changes
Copy link
Member

@gmcculloug gmcculloug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@bdunne bdunne merged commit e22b912 into ManageIQ:master Apr 18, 2017
@bdunne bdunne added this to the Sprint 59 Ending Apr 24, 2017 milestone Apr 18, 2017
simaishi pushed a commit that referenced this pull request Apr 19, 2017
@bdunne @simaishi
Merge pull request #14779 from bzwei/job_play2
b3c8bd7 
Fetch Ansible job plays from job events.
(cherry picked from commit e22b912)

https://bugzilla.redhat.com/show_bug.cgi?id=1443569
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit b3c8bd7cd962008e38fe59214fef965703129538
Author: Brandon Dunne <brandondunne@hotmail.com>
Date:   Tue Apr 18 11:32:33 2017 -0400

    Merge pull request #14779 from bzwei/job_play2
    
    Fetch Ansible job plays from job events.
    (cherry picked from commit e22b912b861487b14b9fb6646c56782f54559267)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1443569

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdunne bdunne bdunne approved these changes

@gmcculloug gmcculloug gmcculloug approved these changes

@syncrou syncrou Awaiting requested review from syncrou

Assignees

@gmcculloug gmcculloug

Labels
bug dependencies fine/backported lifecycle/services providers/automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@bzwei @miq-bot @simaishi @bdunne @gmcculloug @Fryguy