[SCVMM] Allow run_powershell_script method to accept file or string #14854
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment the
run_powershell_script
method in powershell.rb assumes that it's reading from a file. However, for provisioning requests the scripts are inlined as strings (heredocs), causing aErrno::ENAMETOOLONG
error when it tries to read it as a file.https://bugzilla.redhat.com/show_bug.cgi?id=1444201
I've updated the code to make a file check first, and assume that it's a string if it's not found as a file. I've also added some specs.