[FINE] Fix Cockpit console connectivity for RHEV, AWS, GCE #15303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@martinpovolny, @simaishi could you review? |
|
@bmclaughlin which PR fixes this for AWS/GCE in 'master' branch? |
|
@bmclaughlin agreed. Cloned both BZs for 'Fine' branch. Please use them instead: https://bugzilla.redhat.com/show_bug.cgi?id=1458924 (clone of 1450109) |
bmclaughlin
force-pushed
the
use-public-ip-for-aws-cockpit
branch
from
d325f15
to
dc40b66
Compare
|
Checked commits bmclaughlin/manageiq@3c4ce1e~...dc40b66 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@martinpovolny please approve if this is good to go. Thanks! |
martinpovolny
approved these changes
Jun 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on logic that fixed Cockpit connectivity in RHEV in #15000 to fix connectivity in AWS and GCE. This PR back-ports #15000 to Fine (did not cherry-pick cleanly) and fixes AWS/GCE connectivity as well.
@miq-bot add_labels bug, core
https://bugzilla.redhat.com/show_bug.cgi?id=1458924
https://bugzilla.redhat.com/show_bug.cgi?id=1458925