Fix chargeback report with unassigned rates #15580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otherwise
method ApplicationController.helpers.number_with_delimiter is called
(thru apply_format_function and format_currency_with_delimiter is called)
with parameters:
ApplicationController.helpers.number_to_currency('0.0', {:unit => nil} )
which is causing error.
|
Checked commits lpichler/manageiq@c1111ce~...2564953 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
lpichler
force-pushed
the
fix_chargeback_report_with_unassigned_rates
branch
from
2564953
to
c1111ce
Compare
isimluk
approved these changes
Jul 18, 2017
|
Thanks! Nice catch! 🐁 |
simaishi
pushed a commit
that referenced
this pull request
Jul 19, 2017
…assigned_rates Fix chargeback report with unassigned rates (cherry picked from commit 03df095) https://bugzilla.redhat.com/show_bug.cgi?id=1472837
|
Fine backport details: |
d-m-u
pushed a commit
to d-m-u/manageiq
that referenced
this pull request
Jun 6, 2018
…_with_unassigned_rates Fix chargeback report with unassigned rates (cherry picked from commit 03df095) https://bugzilla.redhat.com/show_bug.cgi?id=1472837
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
caused by #13857
Fill
:unitonly if we can determine unit from ratesotherwise
method
ApplicationController.helpers.number_with_delimiteris called(thru
apply_format_functionandformat_currency_with_delimiteris called)with parameters:
ApplicationController.helpers.number_to_currency('0.0', {:unit => nil} )which is causing the error.
Test Scenario
it will throw an error,
with this fix it will generate report but without cost values (there are no rates assigned)
Links
https://bugzilla.redhat.com/show_bug.cgi?id=1470546
@miq-bot add_label bug, reporting
@miq-bot assign @gtanzillo
cc @isimluk