Memoize Metric::Capture.capture_cols #15791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
capture_cols will always be the same regardless of when it is called, unless a database update happens to the metrics table, in which the process would be restarted after the migration has happened, and it will get reloaded then. This method is hit frequently on the metrics collectors, so this prevents a bunch of objects from being allocated multiple times when doing perf_capture_realtime: On a sample benchmark for perf_capture_realtime: Before: 20172 objects allocated from this method After: None (after being memoize)
|
Checked commit NickLaMuro@b78b818 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
capture_colswill always be the same regardless of when it is called, unless a database update happens to the metrics table, in which the process would be restarted after the migration has happened anyway, and it will get reloaded then.This method is hit frequently on the metrics collectors, so this prevents a bunch of objects from being allocated multiple times when doing
perf_capture_realtime:On a sample benchmark for
perf_capture_realtime:Links