Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse the serial number during refresh #15992

Merged
merged 1 commit into from Oct 16, 2017

Conversation

borod108
Copy link

Parse the serial number of host during refresh.
This is required for:
https://bugzilla.redhat.com/show_bug.cgi?id=1410183

This is dependent on:
ManageIQ/manageiq-providers-ovirt#97

@borod108
Copy link
Author

@masayag @pkliczewski @jhernand can someone please review?

@pkliczewski
Copy link
Contributor

Is it RHV specific report? I do not see any information about it. If not how it would behave if the information is not there?

@miq-bot
Copy link
Member

miq-bot commented Sep 29, 2017

This pull request is not mergeable. Please rebase and repush.

@agrare
Copy link
Member

agrare commented Oct 3, 2017

@borod108 can you add a screenshot of what this looks like when it is populated and to @pkliczewski's point can you test what happens when it is not populated (i.e. currently every other infra provider)

@borod108
Copy link
Author

borod108 commented Oct 3, 2017

@agrare hi, I will add a screen shot, for others it will just show an empty column, not great :(
Do you know how I can limit it for ovirt provider only?

@agrare
Copy link
Member

agrare commented Oct 3, 2017

@borod108 I think its fine as an empty column, the UI throws exceptions for missing fields sometimes that's all I wanted to check for :)

Parse the serial number of host during refresh.
This is required for:
https://bugzilla.redhat.com/show_bug.cgi?id=1410183
@miq-bot
Copy link
Member

miq-bot commented Oct 3, 2017

Checked commit borod108@848df70 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

Copy link
Member

@agrare agrare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 will merge when dependent PR is merged

@borod108
Copy link
Author

screenshot from 2017-10-15 16-16-30

@borod108
Copy link
Author

@bdunne bdunne merged commit d59c244 into ManageIQ:master Oct 16, 2017
@bdunne bdunne assigned bdunne and unassigned agrare Oct 16, 2017
@bdunne bdunne added the fine/no label Oct 16, 2017
@bdunne bdunne added this to the Sprint 71 Ending Oct 16, 2017 milestone Oct 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants