Enable help menu items by default in the config/settings.yml #16322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skateman
force-pushed
the
enable-help-menu-items
branch
from
21d8019
to
a18e766
Compare
|
Checked commit skateman@a18e766 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@chessbyte can this be merged, Test failures are not related to changes in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UX asked for a global enable/disable feature for each menu item in the help section. We'd like to have the default value as true, so it is necessary to explicitly set them here.
See ManageIQ/manageiq-ui-classic#2238 and https://www.pivotaltracker.com/story/show/150933794