Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix max method on empty array in chargeback storage report #16575

Merged
merged 3 commits into from Dec 1, 2017
Merged

Fix max method on empty array in chargeback storage report #16575

merged 3 commits into from Dec 1, 2017

Commits on Dec 1, 2017

  1. [].max is nil and we need 0 

    this can happen when method ConsumptionWithRollups#sub_metric_rollups
returns empty array when there are no related VimPerformanceState
records
    @lpichler
    lpichler committed Dec 1, 2017
    Copy the full SHA
    6757fe6 View commit details
    Browse the repository at this point in the history

  2. Set current date/time to be later then starting_date

    @lpichler
    lpichler committed Dec 1, 2017
    Copy the full SHA
    4ccd331 View commit details
    Browse the repository at this point in the history

  3. Spec cases when there are no VimPerformanceStates

    @lpichler
    lpichler committed Dec 1, 2017
    Copy the full SHA
    71d629e View commit details
    Browse the repository at this point in the history