Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build VimPerformanceTagValues for utilization charts by tags on the fly #16582

Merged
merged 2 commits into from Jan 2, 2018

Conversation

gtanzillo
Copy link
Member

This PR is the first step towards getting rid of the vim_performance_tag_values table. The table allows for grouping metrics by assigned tags at the timestamp of each metric. This table can get huge with only a few tag categories enabled for rollup. See referenced BZs below.

After digging through the code that uses that table Nick and I discovered that it's not actually used. The table is queried but the contents are not used in the resulting chart. Instead, instances of VimPerformanceTagValue are generate on the fly.

The first commit eliminates queries to the table for report generation. It will still read and write to the table during metrics processing. Will want to remove that too.

The second commit cleans up some of the code to hopefully make it easier to follow.

/cc @carbonin @Fryguy @blomquisg

https://bugzilla.redhat.com/show_bug.cgi?id=1510484
https://bugzilla.redhat.com/show_bug.cgi?id=1514505

@miq-bot
Copy link
Member

miq-bot commented Dec 3, 2017

Checked commits gtanzillo/manageiq@c4b9ed4~...ebf649e with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 1 offense detected

app/models/vim_performance_tag_value.rb

@gtanzillo gtanzillo changed the title [WIP] Build VimPerformanceTagValues for utilization charts by tags on the fly Build VimPerformanceTagValues for utilization charts by tags on the fly Jan 2, 2018
@gtanzillo gtanzillo removed the wip label Jan 2, 2018
@Fryguy Fryguy merged commit bd2fa2f into ManageIQ:master Jan 2, 2018
@Fryguy Fryguy added this to the Sprint 77 Ending Jan 15, 2018 milestone Jan 2, 2018
@Fryguy Fryguy self-assigned this Jan 2, 2018
@Fryguy Fryguy added refactoring and removed bug labels Jan 2, 2018
@Fryguy
Copy link
Member

Fryguy commented Jan 2, 2018

This is gaprindashvili/yes because #16692 needs to be gaprindashvili/yes and that one is dependent on this.

simaishi pushed a commit that referenced this pull request Jan 3, 2018
Build VimPerformanceTagValues for utilization charts by tags on the fly
(cherry picked from commit bd2fa2f)

https://bugzilla.redhat.com/show_bug.cgi?id=1512705
@simaishi
Copy link
Contributor

simaishi commented Jan 3, 2018

Gaprindashvili backport details:

$ git log -1
commit 253a0125507a82124f52179362ae79bdfc08c88f
Author: Jason Frey <fryguy9@gmail.com>
Date:   Tue Jan 2 13:44:30 2018 -0500

    Merge pull request #16582 from gtanzillo/tag-values
    
    Build VimPerformanceTagValues for utilization charts by tags on the fly
    (cherry picked from commit bd2fa2fca0d419795e437aa44e1c76af128a97c1)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1512705

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants