Build VimPerformanceTagValues for utilization charts by tags on the fly #16582
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first step towards getting rid of the
vim_performance_tag_values
table. The table allows for grouping metrics by assigned tags at the timestamp of each metric. This table can get huge with only a few tag categories enabled for rollup. See referenced BZs below.After digging through the code that uses that table Nick and I discovered that it's not actually used. The table is queried but the contents are not used in the resulting chart. Instead, instances of
VimPerformanceTagValue
are generate on the fly.The first commit eliminates queries to the table for report generation. It will still read and write to the table during metrics processing. Will want to remove that too.
The second commit cleans up some of the code to hopefully make it easier to follow.
/cc @carbonin @Fryguy @blomquisg
https://bugzilla.redhat.com/show_bug.cgi?id=1510484
https://bugzilla.redhat.com/show_bug.cgi?id=1514505