Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create an empty CSS file that is outside the asset pipeline #17127

Merged
merged 1 commit into from Mar 9, 2018
Merged

Create an empty CSS file that is outside the asset pipeline #17127

merged 1 commit into from Mar 9, 2018

Conversation

skateman
Copy link
Member

@skateman skateman commented Mar 9, 2018 •
edited

Asset precompilation on appliances is no longer possible, however, in some cases it is necessary to have custom styling applied on a running appliance. Unfortunately we can't put this file into the ui-classic as we want to bypass the asset pipeline.

UI part: ManageIQ/manageiq-ui-classic#3556

https://bugzilla.redhat.com/show_bug.cgi?id=1553353

@skateman skateman mentioned this pull request Mar 9, 2018
Merged
@miq-bot
Copy link
Member

miq-bot commented Mar 9, 2018

Checked commit skateman@fb34b61 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

himdel
himdel approved these changes Mar 9, 2018
View reviewed changes
Copy link
Contributor

@himdel himdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dclarizio dclarizio self-assigned this Mar 9, 2018
@dclarizio dclarizio merged commit 8c70ee0 into ManageIQ:master Mar 9, 2018
@dclarizio dclarizio added this to the Sprint 81 Ending Mar 12, 2018 milestone Mar 9, 2018
@himdel himdel deleted the custom-css branch March 9, 2018 16:09
@himdel himdel restored the custom-css branch March 9, 2018 16:09
simaishi pushed a commit that referenced this pull request Mar 9, 2018
@simaishi
Merge pull request #17127 from skateman/custom-css
11d9dfc 
Create an empty CSS file that is outside the asset pipeline
(cherry picked from commit 8c70ee0)

https://bugzilla.redhat.com/show_bug.cgi?id=1553841
@simaishi
Copy link
Contributor

simaishi commented Mar 9, 2018

Gaprindashvili backport details:

$ git log -1
commit 11d9dfc28e4421a58a15b12dcd81f2686659ea4d
Author: Dan Clarizio <dclarizi@redhat.com>
Date:   Fri Mar 9 08:01:13 2018 -0800

    Merge pull request #17127 from skateman/custom-css
    
    Create an empty CSS file that is outside the asset pipeline
    (cherry picked from commit 8c70ee02f544a1049d60dc3fd5e5d67fc5c44197)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1553841

@skateman skateman deleted the custom-css branch March 9, 2018 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himdel himdel himdel approved these changes

Assignees

@dclarizio dclarizio

Labels
enhancement gaprindashvili/backported ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@skateman @miq-bot @simaishi @himdel @dclarizio