Don't ignore errors in Vm#running_processes #17220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure who best to review this as the code is so ancient, @bdunne what do you think? |
agrare
force-pushed
the
bz_1534023_running_processes_dont_eat_exception
branch
2 times, most recently
from
6ecb7ee
to
b88bc68
Compare
bdunne
approved these changes
Mar 28, 2018
Hm right we want it to try the next IP address, but then if they all fail we want to raise an error... |
|
I gave it some bogus creds and the connect doesn't fail, it does throw an exception deep down in |
|
@bdunne What do you think about just raising the validation errors since that should catch most of the issues |
The Vm#running_processes method currently logs all errors/exceptions instead of raising them up. This causes the tasks to look like they were successful even though there are warnings in the log about mis-configuration which should be corrected by the user. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1534023
agrare
force-pushed
the
bz_1534023_running_processes_dont_eat_exception
branch
from
b88bc68
to
b187c43
Compare
|
Checked commit agrare@b187c43 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
bdunne
approved these changes
Mar 29, 2018
|
Thanks @bdunne ! |
simaishi
pushed a commit
that referenced
this pull request
Apr 2, 2018
…nt_eat_exception Don't ignore errors in Vm#running_processes (cherry picked from commit c6c282a) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1562780
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Vm#running_processes method currently logs all errors/exceptions
instead of raising them up. This causes the tasks to look like they
were successful even though there are warnings in the log about
mis-configuration which should be corrected by the user.
The bottom two tasks were from before this change, they actually failed but look successful in the task list. The top two tasks were from after this change.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1534023