Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add delete notification types for Network Router #17514

Merged
merged 1 commit into from Oct 9, 2018
Merged

Add delete notification types for Network Router #17514

merged 1 commit into from Oct 9, 2018

Conversation

andyvesel
Copy link
Contributor

Added notification types network_router_delete_success and network_router_delete_error
Relevant BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1518734

@andyvesel andyvesel mentioned this pull request Jun 7, 2018
Merged
@mansam
Copy link
Contributor

mansam commented Jun 13, 2018

LGTM

@miq-bot
Copy link
Member

miq-bot commented Aug 13, 2018

This pull request is not mergeable. Please rebase and repush.

@miq-bot
Copy link
Member

miq-bot commented Aug 24, 2018

This pull request is not mergeable. Please rebase and repush.

@miq-bot
Copy link
Member

miq-bot commented Sep 25, 2018

Checked commit andyvesel@cd9916c with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

skateman
skateman approved these changes Oct 9, 2018
View reviewed changes
Copy link
Member

@skateman skateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Seal of Approval

@agrare agrare self-assigned this Oct 9, 2018
@martinpovolny martinpovolny merged commit c8506fa into ManageIQ:master Oct 9, 2018
@martinpovolny martinpovolny added this to the Sprint 97 Ending Oct 22, 2018 milestone Oct 9, 2018
@martinpovolny martinpovolny assigned martinpovolny and unassigned agrare Oct 9, 2018
@mansam
Copy link
Contributor

mansam commented Dec 14, 2018

It appears that this needs to be backported to 5.10.z in order to resolve https://bugzilla.redhat.com/show_bug.cgi?id=1655704

It looks like the provider side change got included in Hammer, but this side of it wasn't. ManageIQ/manageiq-providers-openstack@f58bbf4

@mansam
Copy link
Contributor

mansam commented Dec 14, 2018

@miq-bot add_label hammer/yes

@mansam
Copy link
Contributor

mansam commented Jan 8, 2019

@simaishi Can this be backported to hammer to fix https://bugzilla.redhat.com/show_bug.cgi?id=1655704?

@simaishi
Copy link
Contributor

simaishi commented Jan 8, 2019

@mansam I can backport PRs only for blocker BZ at this point. Since that BZ isn't marked as blocker, I'm not able to backport...

@mansam
Copy link
Contributor

mansam commented Jan 9, 2019

Gotcha, thanks @simaishi

@mansam
Copy link
Contributor

mansam commented Mar 18, 2019

@Loicavenel @simaishi Will there be any further opportunities for this to make it in to 5.10.z? https://bugzilla.redhat.com/show_bug.cgi?id=1655704 and https://bugzilla.redhat.com/show_bug.cgi?id=1518734 are both targeted at 5.10 and would need this PR to be resolved.

@Loicavenel
Copy link

@mansam if the PR is merged can you move it to Post please.. then duding next triage we may include it.

simaishi pushed a commit that referenced this pull request Apr 23, 2019
@simaishi
Merge pull request #17514 from andyvesel/add_notification
1bb2729 
Add delete notification types for Network Router

(cherry picked from commit c8506fa)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1702477
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit 1bb2729867a56bf34ede2ba5144a29c83df985bc
Author: Martin Povolny <mpovolny@redhat.com>
Date:   Tue Oct 9 16:14:13 2018 +0200

    Merge pull request #17514 from andyvesel/add_notification
    
    Add delete notification types for Network Router
    
    (cherry picked from commit c8506faa54f5b6d3489a98ed87a9b957e72fbcbd)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1702477

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skateman skateman skateman approved these changes

Assignees

@martinpovolny martinpovolny

Labels
enhancement hammer/backported providers/network
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@andyvesel @mansam @miq-bot @simaishi @Loicavenel @skateman @martinpovolny @agrare