Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delete notification types for Network Router #17514

Merged
merged 1 commit into from Oct 9, 2018

Conversation

@andyvesel
Copy link
Contributor

commented Jun 4, 2018

Added notification types network_router_delete_success and network_router_delete_error
Relevant BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1518734

@andyvesel andyvesel force-pushed the andyvesel:add_notification branch from 9768dc4 to f7b57c0 Jun 4, 2018
@mansam

This comment has been minimized.

Copy link
Contributor

commented Jun 13, 2018

LGTM

@miq-bot

This comment has been minimized.

Copy link
Member

commented Aug 13, 2018

This pull request is not mergeable. Please rebase and repush.

@miq-bot miq-bot added the unmergeable label Aug 13, 2018
@andyvesel andyvesel force-pushed the andyvesel:add_notification branch from f7b57c0 to 02a4d1a Aug 23, 2018
@miq-bot miq-bot removed the unmergeable label Aug 23, 2018
@miq-bot

This comment has been minimized.

Copy link
Member

commented Aug 24, 2018

This pull request is not mergeable. Please rebase and repush.

@miq-bot miq-bot added unmergeable and removed unmergeable labels Aug 24, 2018
@andyvesel andyvesel force-pushed the andyvesel:add_notification branch from 1ce6a24 to cd9916c Sep 25, 2018
@miq-bot

This comment has been minimized.

Copy link
Member

commented Sep 25, 2018

Checked commit andyvesel@cd9916c with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

Copy link
Member

left a comment

The Seal of Approval

@agrare agrare self-assigned this Oct 9, 2018
@martinpovolny martinpovolny merged commit c8506fa into ManageIQ:master Oct 9, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.004%) to 73.012%
Details
@martinpovolny martinpovolny assigned martinpovolny and unassigned agrare Oct 9, 2018
@mansam

This comment has been minimized.

Copy link
Contributor

commented Dec 14, 2018

It appears that this needs to be backported to 5.10.z in order to resolve https://bugzilla.redhat.com/show_bug.cgi?id=1655704

It looks like the provider side change got included in Hammer, but this side of it wasn't. ManageIQ/manageiq-providers-openstack@f58bbf4

@mansam

This comment has been minimized.

Copy link
Contributor

commented Dec 14, 2018

@miq-bot add_label hammer/yes

@miq-bot miq-bot added the hammer/yes label Dec 14, 2018
@mansam

This comment has been minimized.

Copy link
Contributor

commented Jan 8, 2019

@simaishi Can this be backported to hammer to fix https://bugzilla.redhat.com/show_bug.cgi?id=1655704?

@simaishi

This comment has been minimized.

Copy link
Contributor

commented Jan 8, 2019

@mansam I can backport PRs only for blocker BZ at this point. Since that BZ isn't marked as blocker, I'm not able to backport...

@mansam

This comment has been minimized.

Copy link
Contributor

commented Jan 9, 2019

Gotcha, thanks @simaishi

@mansam

This comment has been minimized.

Copy link
Contributor

commented Mar 18, 2019

@Loicavenel @simaishi Will there be any further opportunities for this to make it in to 5.10.z? https://bugzilla.redhat.com/show_bug.cgi?id=1655704 and https://bugzilla.redhat.com/show_bug.cgi?id=1518734 are both targeted at 5.10 and would need this PR to be resolved.

@Loicavenel

This comment has been minimized.

Copy link

commented Mar 18, 2019

@mansam if the PR is merged can you move it to Post please.. then duding next triage we may include it.

simaishi added a commit that referenced this pull request Apr 23, 2019
Add delete notification types for Network Router

(cherry picked from commit c8506fa)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1702477
@simaishi

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

Hammer backport details:

$ git log -1
commit 1bb2729867a56bf34ede2ba5144a29c83df985bc
Author: Martin Povolny <mpovolny@redhat.com>
Date:   Tue Oct 9 16:14:13 2018 +0200

    Merge pull request #17514 from andyvesel/add_notification
    
    Add delete notification types for Network Router
    
    (cherry picked from commit c8506faa54f5b6d3489a98ed87a9b957e72fbcbd)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1702477
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.