Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No event will be shown when a compliance policy is created for a Physical Infra #17516

Merged
merged 1 commit into from Jun 11, 2018

Conversation

felipedf
Copy link
Member

@felipedf felipedf commented Jun 4, 2018

This is a fix for Physical Infra Provider where there is no event shown when a compliance policy is created.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1565576

@felipedf
Copy link
Member Author

felipedf commented Jun 4, 2018

@miq-bot add_label bug

@miq-bot miq-bot added the bug label Jun 4, 2018
@felipedf
Copy link
Member Author

felipedf commented Jun 5, 2018

@rodneyhbrown7

@felipedf
Copy link
Member Author

@miq-bot assign @agrare

@agrare
Copy link
Member

agrare commented Jun 11, 2018

@felipedf can you add https://bugzilla.redhat.com/show_bug.cgi?id=1565576 to the description of your commit message? That way it will move the BZ to POST when this is merged.

@felipedf
Copy link
Member Author

Done :D

@agrare
Copy link
Member

agrare commented Jun 11, 2018

@felipedf I think it has to be on its own line, also can you limit the first line of your commit message to the 50 char limit (see how it is wrapped onto the next line)

@miq-bot
Copy link
Member

miq-bot commented Jun 11, 2018

Checked commit felipedf@a1523e9 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

Copy link
Member

@agrare agrare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gtanzillo gtanzillo added this to the Sprint 88 Ending Jun 18, 2018 milestone Jun 11, 2018
@gtanzillo gtanzillo merged commit afae58a into ManageIQ:master Jun 11, 2018
@agrare
Copy link
Member

agrare commented Jun 12, 2018

@felipedf it looks like this didn't link to the BZ correctly.

Just to summarize you should put the BZ link in the PR description and in the commit message.
It should be either by itself or with a Fixes prefix if it is the only PR/commit.

Look at #17537 as an example.

@JPrause
Copy link
Member

JPrause commented Jun 12, 2018

@miq-bot add_label blocker

@felipedf
Copy link
Member Author

@agrare I fixed the PR message, but I guess the commit message is wrong :'(

simaishi pushed a commit that referenced this pull request Jun 14, 2018
No event will be shown when a compliance policy is created for a Physical Infra
(cherry picked from commit afae58a)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1591423
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit d7ea8ee45115eac0b7f3d191f00e96e13f4db259
Author: Gregg Tanzillo <gtanzill@redhat.com>
Date:   Mon Jun 11 15:41:33 2018 -0400

    Merge pull request #17516 from felipedf/BZ156557
    
    No event will be shown when a compliance policy is created for a Physical Infra
    (cherry picked from commit afae58a918552f9d754b7d9a03962bdda0631283)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1591423

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants