Fix spec test to resolve sporadic test failure. #17730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tinaafitz
force-pushed
the
fix_retirement_spec
branch
from
0b9fbe1
to
e5e504d
Compare
agrare
reviewed
Jul 19, 2018
| @@ -13,7 +13,7 @@ | |||
| @stack.retirement_check | |||
| @stack.reload | |||
| expect(@stack.retirement_last_warn).not_to be_nil | |||
| expect(Time.now.utc - @stack.retirement_last_warn).to be < 30 | |||
| expect(Time.now.utc - @stack.retirement_last_warn).not_to be_nil | |||
There was a problem hiding this comment.
@tinaafitz is this essentially the same check as line 15?
tinaafitz
force-pushed
the
fix_retirement_spec
branch
from
e5e504d
to
9e140f4
Compare
agrare
approved these changes
Jul 19, 2018
|
Checked commit tinaafitz@9e140f4 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
agrare
added a commit
that referenced
this pull request
Jul 19, 2018
Fix spec test to resolve sporadic test failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix spec for Test Failure:
Failure/Error: expect(Time.now.utc - @vm.retirement_last_warn).to be < 30
expected: < 30
got: 31.175546782