Correctly pass dialog field values through request #17839
Conversation
|
@miq-bot add_label bug |
| @@ -89,6 +89,7 @@ def validate_field_data | |||
| end | |||
|
|
|||
| def load_values_into_fields(values) | |||
| values = values.with_indifferent_access | |||
There was a problem hiding this comment.
Would this change be required in initialize_with_given_values below where we are doing the same key lookup?
There was a problem hiding this comment.
In theory, it wouldn't hurt I guess. In practice that path is only being used by reconfigure and uses the contents of options[:dialog] within a service.
There was a problem hiding this comment.
Ok, wanted to make sure we had considered this code path. If you are saying it is good then we do not need the change.
d-m-u
changed the title
d-m-u
changed the title
d-m-u
changed the title
miq-bot
changed the title
app/models/service_template.rb
Outdated
| @@ -380,6 +380,8 @@ def self.create_from_options(options) | |||
| private_class_method :create_from_options | |||
|
|
|||
| def provision_request(user, options = nil, request_options = nil) | |||
| request_options ||= {} | |||
| request_options[:submit_workflow] = true | |||
There was a problem hiding this comment.
Let's change the method definition to use request_options = {}
Then you do not need the first line to initialize it.
|
@miq-bot add_label blocker |
|
@d-m-u if this will be able to be backported, can you add the gaprindashvili/yes label |
|
Checked commits d-m-u/manageiq@bbf06ef~...1d05596 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
d-m-u
changed the title
|
@miq-bot remove_label wip |
|
@miq-bot add_label gaprindashvili/yes |
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1613935
This is two small changes.
with_indifferent_access added to dialog field lookup
#17642 broke our setting values in fields because previously we were setting the names to strings in the lookup
submit_workflow utilized in requests
The submit_workflow option is used to funnel values correctly through requests.