Core fixes for infra graph refresh #17870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrare
commented
Aug 17, 2018
| @@ -132,6 +132,8 @@ def collect_inventory_for_targets(ems, targets) | |||
| # override this method and return an array of: | |||
| # [[target1, inventory_for_target1], [target2, inventory_for_target2]] | |||
|
|
|||
| return [[ems, nil]] unless refresher_options.inventory_object_refresh | |||
There was a problem hiding this comment.
If there wasn't a collect_inventory_for_targets method this would always use graph refresh even if it was disabled in settings.
|
Hey @gtanzillo can you take a look? |
gtanzillo
approved these changes
Aug 28, 2018
|
@agrare I can merge once the conflicts are resolved |
agrare
force-pushed
the
core_fixes_for_infra_graph_refresh
branch
from
d0da4c4
to
babdd06
Compare
|
Checked commits agrare/manageiq@4bc7387~...babdd06 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@gtanzillo thanks I didn't notice it was conflicting, rebased and green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fixes to the infra inventory_collections for InfraManager graph refresh
Needed for: