Add product setting default for allowing API service ordering #18029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is not mergeable. Please rebase and repush. |
eclarizio
force-pushed
the
BZ1632416-Addendum
branch
from
4c6c460
to
5517c40
Compare
|
Checked commit eclarizio@5517c40 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@miq-bot add_label blocker |
|
@eclarizio is this will be able to be backported, can you add the hammer/yes and gaprindashvili/yes labels |
|
@miq-bot add_label gaprindashvili/yes, hammer/yes |
simaishi
pushed a commit
that referenced
this pull request
Oct 22, 2018
Add product setting default for allowing API service ordering (cherry picked from commit e65f4d3) https://bugzilla.redhat.com/show_bug.cgi?id=1632416
|
Hammer backport details: |
simaishi
pushed a commit
that referenced
this pull request
Nov 5, 2018
Add product setting default for allowing API service ordering (cherry picked from commit e65f4d3) https://bugzilla.redhat.com/show_bug.cgi?id=1646435
|
Gaprindashvili backport details: |
nizaminabeel
pushed a commit
to nizaminabeel/manageiq
that referenced
this pull request
Dec 11, 2018
Add product setting default for allowing API service ordering (cherry picked from commit e65f4d3) https://bugzilla.redhat.com/show_bug.cgi?id=1646435
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an addition to this PR, @bdunne suggested I change the product setting to a positive name and default the value to
true.https://bugzilla.redhat.com/show_bug.cgi?id=1632416
I know there's not much to "review" here, but @bdunne, can you give it a look? 馃憖
/cc @tinaafitz
@miq-bot add_label bug