RHV requires disconnect_storage before ems #18330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RHV disconnect_storage has to perform an API call to the provider to check if the underlying disks are still on the datastore. In order to do this it must still have its ext_management_system link to be able to connect. This means that disconnect_storage must be called prior to disconnect_ems. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1659340
gtanzillo
approved these changes
Jan 4, 2019
simaishi
pushed a commit
that referenced
this pull request
Jan 7, 2019
…ct_order RHV requires disconnect_storage before ems (cherry picked from commit be1857c) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1659340
|
Hammer backport details: |
simaishi
pushed a commit
that referenced
this pull request
Jan 8, 2019
…ct_order RHV requires disconnect_storage before ems (cherry picked from commit be1857c) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1664470
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RHV disconnect_storage has to perform an API call to the provider to
check if the underlying disks are still on the datastore. In order to
do this it must still have its ext_management_system link to be able to
connect. This means that disconnect_storage must be called prior to
disconnect_ems.
Introduced by cleanup done in ManageIQ/manageiq-providers-ovirt#310
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1659340