Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't format chargeback rate column in MiqReport::Formatting #18431

Merged
merged 1 commit into from
Feb 19, 2019

Conversation

lpichler
Copy link
Contributor

@lpichler lpichler commented Feb 5, 2019

This is not best fix but usable for backport

Issue:
Some of "float" format was taken for chargeback rate columns which are strings.
Solution is to don't format such columns

[----] E, [2018-11-01T11:25:45.469900 #11829:93af80] ERROR -- : /opt/rh/cfme-gemset/bundler/gems/cfme-ui-classic-75b755f67a94/app/helpers/number_helper.rb:53:in `Float'
/opt/rh/cfme-gemset/bundler/gems/cfme-ui-classic-75b755f67a94/app/helpers/number_helper.rb:53:in `handling_negatives'
/opt/rh/cfme-gemset/bundler/gems/cfme-ui-classic-75b755f67a94/app/helpers/number_helper.rb:4:in `number_to_human_size'
/var/www/miq/vmdb/app/models/miq_report/formatting.rb:122:in `format_bytes_to_human_size'
/var/www/miq/vmdb/app/models/miq_report/formatting.rb:90:in `apply_format_function'
/var/www/miq/vmdb/app/models/miq_report/formatting.rb:75:in `format'

Links

@miq-bot assign @gtanzillo
@miq-bot add_label hammer/yes, bug, chargeback

@miq-bot
Copy link
Member

miq-bot commented Feb 12, 2019

Checked commit lpichler@bad74a9 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. ⭐

Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gtanzillo gtanzillo merged commit 80bcb81 into ManageIQ:master Feb 19, 2019
@lpichler lpichler deleted the dont_format_rate_column branch February 28, 2019 12:44
@agrare agrare added this to the Sprint 106 Ending Mar 4, 2019 milestone Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants