Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add factory for service retire request #18685

Merged

Conversation

d-m-u
Copy link
Contributor

@d-m-u d-m-u commented Apr 24, 2019

This factory is needed for me to be able to test the self.create_retire_request(obj) in ManageIQ/manageiq-automation_engine#314

part of fix for https://bugzilla.redhat.com/show_bug.cgi?id=1700524

Related to:

ManageIQ/manageiq-automation_engine#314

@d-m-u
Copy link
Contributor Author

d-m-u commented Apr 24, 2019

@miq-bot assign @tinaafitz
@miq-bot add_label bug
@miq-bot add_label hammer/yes

@miq-bot
Copy link
Member

miq-bot commented Apr 24, 2019

Checked commit d-m-u@17e60de with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@d-m-u
Copy link
Contributor Author

d-m-u commented Apr 24, 2019

@miq-bot add_label test

@miq-bot miq-bot added the test label Apr 24, 2019
@mkanoor mkanoor merged commit 58b5dbd into ManageIQ:master Apr 24, 2019
@mkanoor mkanoor added this to the Sprint 110 Ending Apr 29, 2019 milestone Apr 24, 2019
@d-m-u d-m-u deleted the adding_factory_for_service_retire_request branch April 24, 2019 19:51
simaishi pushed a commit that referenced this pull request Sep 19, 2019
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit a2167c9daafdd187b2d28a169259f51fd0d1366c
Author: Madhu Kanoor <mkanoor@redhat.com>
Date:   Wed Apr 24 15:49:12 2019 -0400

    Merge pull request #18685 from d-m-u/adding_factory_for_service_retire_request
    
    Add factory for service retire request
    
    (cherry picked from commit 58b5dbd2b7be407ee1ba1d03c8a332ba9cf8599e)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1753669

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants