Save playbook set_stats data for successive playbook methods #18889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which will be used as the name for ManageIQ::Providers::EmbeddedAnsible::AutomationManager::Job. https://bugzilla.redhat.com/show_bug.cgi?id=1678135
lfu
force-pushed
the
playbook_method_parameters_1678135
branch
from
52c8eac
to
ca38a0c
Compare
|
Checked commits lfu/manageiq@1eaaa52~...ca38a0c with ruby 2.3.3, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
mkanoor
reviewed
Jun 21, 2019
| @@ -164,6 +165,7 @@ def queue_signal(*args, deliver_on: nil) | |||
|
|
|||
| def temp_configuration_script | |||
| ManageIQ::Providers::EmbeddedAnsible::AutomationManager::ConfigurationScript.new( | |||
| :name => playbook.name, | |||
There was a problem hiding this comment.
@lfu Where is the name going to get used?
There was a problem hiding this comment.
That name will be used for ManageIQ::Providers::EmbeddedAnsible::AutomationManager::Job.
mkanoor
approved these changes
Jun 24, 2019
tinaafitz
approved these changes
Jun 26, 2019
|
@gmcculloug Please review |
|
@gmcculloug Please review. |
|
@miq-bot add_label changelog/yes |
|
@lfu unrecognized command 'add_lable', ignoring... Accepted commands are: add_label, add_reviewer, assign, close_issue, move_issue, remove_label, rm_label, remove_reviewer, set_milestone |
|
@NickLaMuro @carbonin FYI, not sure you all saw this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set_stats data in a playbook would be saved and passed to successive playbook methods via automate workspace.
Part of ManageIQ/manageiq-automation_engine#333
https://bugzilla.redhat.com/show_bug.cgi?id=1678135
@miq-bot assign @tinaafitz
@miq-bot add_label enhancement, automate