Fix VM Retirement Error Message #19710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tinaafitz
force-pushed
the
fix_retirement_message
branch
2 times, most recently
from
6b8b51f
to
0e9fa7d
Compare
tinaafitz
force-pushed
the
fix_retirement_message
branch
3 times, most recently
from
1710d77
to
e342d53
Compare
tinaafitz
force-pushed
the
fix_retirement_message
branch
from
e342d53
to
7435dce
Compare
|
Checked commit tinaafitz@7435dce with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
tinaafitz
changed the title
|
@tinaafitz can this be |
|
@tinaafitz Cannot apply the following label because they are not recognized: changelog/yes hammer/yes ivanchuk/yes |
|
@miq-bot add_label bug, hammer/yes, ivanchuk/yes, changelog/yes |
|
Hi @simaishi Yes, I added the labels, thanks. |
|
@tinaafitz The backport conflicts on spec file as |
This was referenced Feb 6, 2020
|
Backported to hammer via #19821 |
|
Backported to ivanchuk via #19820 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue error log message only if there are invalid src_ids.
The following error log message is unconditional. It should only be issued when src_ids contains at least one invalid vm id.
[----] E, [2020-01-13T12:50:10.880878 #10833:46b5e3c] ERROR -- : MIQ(Vm.make_retire_request) Retirement of [Vm] IDs: [] skipped - target(s) does not exist
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1789806