Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the journald logger to resolve segfaults #20004

Merged
merged 1 commit into from
Mar 24, 2020
Merged

Remove the journald logger to resolve segfaults #20004

merged 1 commit into from
Mar 24, 2020

Conversation

agrare
Copy link
Member

@agrare agrare commented Mar 24, 2020 •
edited
Loading

Sometimes the journald logger segfaults, remove it until this can be further investigated:
/usr/local/lib/ruby/gems/2.6.0/gems/systemd-journal-1.4.1/lib/systemd/journal/writable.rb:69: [BUG] Segmentation fault at 0x0000000000000c91

@agrare
Remove the journald logger to resolve segfaults
c72ffa5 
Sometimes the journald logger segfaults, remove it until this can be
further investigated:
`/usr/local/lib/ruby/gems/2.6.0/gems/systemd-journal-1.4.1/lib/systemd/journal/writable.rb:69:
[BUG] Segmentation fault at 0x0000000000000c91`
@agrare agrare force-pushed the remove_journald_multicast_logger branch from 7abf3b5 to c72ffa5 Compare March 24, 2020 14:53
@miq-bot
Copy link
Member

miq-bot commented Mar 24, 2020

Checked commit agrare@c72ffa5 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@agrare
Copy link
Member Author

agrare commented Mar 24, 2020

Given that I can send the first 8192 UTF-8 chars I'd be surprised if this was because of the string that was sent but its still possible.

I wonder if there was a malloc failure that returned a null pointer that wasn't being checked.

@agrare
Copy link
Member Author

agrare commented Mar 24, 2020

@Fryguy travis is green https://travis-ci.org/github/ManageIQ/manageiq/builds/666371473?utm_source=github_status&utm_medium=notification

@Fryguy Fryguy merged commit 1283535 into ManageIQ:master Mar 24, 2020
@agrare agrare deleted the remove_journald_multicast_logger branch March 24, 2020 15:42
simaishi pushed a commit that referenced this pull request Mar 24, 2020
@Fryguy @simaishi
Merge pull request #20004 from agrare/remove_journald_multicast_logger
ea75792 
Remove the journald logger to resolve segfaults

(cherry picked from commit 1283535)
@simaishi
Copy link
Contributor

Jansa backport details:

$ git log -1
commit ea75792f8bb2737693fb3626648d56e9b902fccb
Author: Jason Frey <fryguy9@gmail.com>
Date:   Tue Mar 24 11:33:30 2020 -0400

    Merge pull request #20004 from agrare/remove_journald_multicast_logger

    Remove the journald logger to resolve segfaults

    (cherry picked from commit 1283535e41099a9c34cebdb27aac83c151fbb70d)

@djberg96 djberg96 mentioned this pull request Jul 30, 2020
Closed
@djberg96
Copy link
Contributor

ledbettj/systemd-journal#90 might solve the original issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fryguy Fryguy Fryguy left review comments

@gtanzillo gtanzillo Awaiting requested review from gtanzillo

Assignees

@Fryguy Fryguy

Labels
appliance bug jansa/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@agrare @miq-bot @simaishi @djberg96 @Fryguy