Made changes to code to not save blank resource action #2961
Conversation
h-kataria
force-pushed
the
dont_save_blank_resource_action
branch
3 times, most recently
from
e08d81b
to
b68f819
Compare
| else | ||
| ra.dialog = d | ||
| ra.fqname = @edit[:new][action[:edit_key]].blank? ? nil : @edit[:new][action[:edit_key]] | ||
| ra.save! |
There was a problem hiding this comment.
You do not need the check for @edit[:new][action[:edit_key]] being blank since that case is handled by the if statement.
The then entire else section could be reduced to:
ra.update_attributes(:dialog => d, :fqname => @edit[:new][action[:edit_key]])
h-kataria
force-pushed
the
dont_save_blank_resource_action
branch
from
b68f819
to
27a2bbc
Compare
|
@gmcculloug made suggested changes. |
h-kataria
force-pushed
the
dont_save_blank_resource_action
branch
from
27a2bbc
to
3c7c259
Compare
| @@ -1214,7 +1214,7 @@ def trees_to_replace(trees) | |||
| end | |||
|
|
|||
| def set_resource_action(st) | |||
| d = @edit[:new][:dialog_id].nil? ? nil : Dialog.find_by_id(@edit[:new][:dialog_id]) | |||
| d = @edit[:new][:dialog_id].nil? ? nil : Dialog.where(:id => @edit[:new][:dialog_id].to_i).first | |||
There was a problem hiding this comment.
You do not need to call .to_i.
|
@h-kataria One additional comment and could you also take a look at the recommended spec changes. |
|
@gmcculloug i will make the suggested change, not sure which spec change you are reffering to, i had already made suggested changes to spec test from your previous suggestions |
|
@h-kataria I was expecting my comments to be marked as outdated diffs. You do not need the length check anymore since that is covered by the match_array check. |
- Dont add a blank resource action when saving catalog item. - Delete empty/blank resource action when user has removed entry point while editing Catalog Item. Changed code that sets entry points to nil when displaying a Catalog Item, it was displaying incorrect values even after entry point was removed. - Added spec test to verify blank resource action does not get saved. https://bugzilla.redhat.com/show_bug.cgi?id=1221333
h-kataria
force-pushed
the
dont_save_blank_resource_action
branch
from
3c7c259
to
f194cbd
Compare
|
@gmcculloug made suggested changes, please re-review. |
|
Checked commit h-kataria@f194cbd with rubocop 0.27.1 |
Made changes to code to not save blank resource action
https://bugzilla.redhat.com/show_bug.cgi?id=1221333
@gmcculloug please review/test. If this looks good i will work on adding a spec test around this.