Storage: Fixed the process_button method to render the page correctly #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -108,6 +108,7 @@ def process_button | |||
| if @refresh_div == "main_div" && @lastaction == "show_list" | |||
| replace_gtl_main_div | |||
| else | |||
| @ems = identify_record(params[:id]) | |||
There was a problem hiding this comment.
@AparnaKarve why do we need to set @ems in cim_instance controller.
There was a problem hiding this comment.
@h-kataria Check out line#119 below.
page.replace_html("main_div", :partial=>"layouts/gtl", :locals=>{:action_url=>"show/{@ems.id}"})
@ems is being used there without being set, which was causing the rendering to blow up.
But since its not being used anywhere else in the cim_instance controller we can get rid of it and change it to a local variable.
There was a problem hiding this comment.
@AparnaKarve dont we have @record that we could have used on line 119
There was a problem hiding this comment.
@h-kataria Yes, looks like we can use @record here.
I will push the update shortly.
Rendering errors that occurred after the refresh/power button tasks were addressed in the Storage area in the VM/Hosts associations issue ManageIQ#243
|
Checked commit AparnaKarve@5552423 with rubocop 0.21.0 |
dclarizio
pushed a commit
that referenced
this pull request
Aug 6, 2014
…ions_gh_issue_243 Storage: Fixed the process_button method to render the page correctly
simaishi
pushed a commit
that referenced
this pull request
Jul 31, 2018
Use the full URI for the broker connection (cherry picked from commit 675cc09cac238bfa52850a46d447afa2a9143aa2) https://bugzilla.redhat.com/show_bug.cgi?id=1608552
simaishi
pushed a commit
that referenced
this pull request
Aug 14, 2018
Use the full URI for the broker connection (cherry picked from commit 675cc09cac238bfa52850a46d447afa2a9143aa2) https://bugzilla.redhat.com/show_bug.cgi?id=1603578
tumido
pushed a commit
to tumido/manageiq
that referenced
this pull request
Aug 31, 2018
…onnection Use the full URI for the broker connection (cherry picked from commit 675cc09cac238bfa52850a46d447afa2a9143aa2) https://bugzilla.redhat.com/show_bug.cgi?id=1603578
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendering errors that occurred after the refresh/power button tasks were addressed in the Storage area in the VM/Hosts list view.
issue #243