Fix MiqWidget#grouped_subscribers #3115
Merged
+52
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -132,6 +132,33 @@ | |||
| result[@group2].should match_array(users) | |||
| end | |||
|
|
|||
| it 'ignores the user that does not exist any more' do | |||
| ws = FactoryGirl.create(:miq_widget_set, :name => "Home", :userid => @user1.userid, :group_id => @group1.id) | |||
| @widget_report_vendor_and_guest_os.make_memberof(ws) | |||
There was a problem hiding this comment.
@lfu These two lines are repeated at the top of every test in this context except the first one. Let's create a sub-context and move this logic into a before block.
lfu
force-pushed
the
widget_group_with_nil_user_1227426
branch
from
efdb399
to
5dbd12e
Compare
|
@gmcculloug Updated. |
when a user is deleted somehow. Normally when a user is removed, say from UI, the associated dashboard is cleared as well. But during this customer's migration from 3.0 to 3.1, looks like some users got deleted and left behind the dashboards in DB. https://bugzilla.redhat.com/show_bug.cgi?id=1227426
to skip the user that does not exist any more. Normally when a user is removed, say from UI, the associated dashboard is cleared as well. But during this customer's migration from 3.0 to 3.1, looks like some users got deleted and left behind the dashboards in DB. https://bugzilla.redhat.com/show_bug.cgi?id=1227426
lfu
force-pushed
the
widget_group_with_nil_user_1227426
branch
from
5dbd12e
to
cc8df7f
Compare
|
Checked commits lfu@6197406 .. lfu@cc8df7f with rubocop 0.27.1 |
gmcculloug
added a commit
that referenced
this pull request
Jun 18, 2015
Fix MiqWidget#grouped_subscribers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to skip the user that does not exist any more.
Normally when a user is removed, say from UI, the associated dashboards are cleared as well.
But during this customer's migration from 3.0 to 3.1, looks like some users got deleted and left behind the dashboards in DB.
https://bugzilla.redhat.com/show_bug.cgi?id=1227426