-
Notifications
You must be signed in to change notification settings - Fork 899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I18n various pieces #3118
I18n various pieces #3118
Conversation
ACK :) |
Review fixes.
@himdel : fixed + removed the line of javascript that seems to be dead code as there's no |
Checked commits martinpovolny@dff5413 .. martinpovolny@79e3d78 with rubocop 0.27.1 vmdb/app/controllers/configuration_controller.rb
vmdb/app/views/dashboard/_login_more.html.haml
vmdb/app/views/layouts/_user_options.html.haml
|
@himdel : so with the last change we are good to merge, right? |
@martinpovolny right :) |
I18n Menu sections
https://bugzilla.redhat.com/show_bug.cgi?id=1225395
I18n sub-tabs name of Configure -> My Settings
https://bugzilla.redhat.com/show_bug.cgi?id=1225401
I18n app/views/dashboard/_login_more.html.haml
https://bugzilla.redhat.com/show_bug.cgi?id=1225380
I18n app/views/layouts/_user_options.html.haml
https://bugzilla.redhat.com/show_bug.cgi?id=1225432
I will update the .po files in a different PR because that is a hell to rebase and will have to be redone for the production anyway...
Replaces #3046 and #3043