Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct tasks description. #3221

Merged

Conversation

imtayadeway
Copy link
Contributor

Both 'tasks' and 'request tasks' had the same description of 'Request
Tasks'. This change gives tasks a distinct description of simply
'Tasks'.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1232924

@imtayadeway
Copy link
Contributor Author

@abellotti thanks for the heads up on this one. Hope this changes the right thing - still diving in.

@Fryguy
Copy link
Member

Fryguy commented Jun 22, 2015

@abellotti Please review.

@Fryguy
Copy link
Member

Fryguy commented Jun 22, 2015

@imtayadeway Please change the commit message to have the BZ URL on its own line (without the "Fixes" keyword), so the bot can pick it up. I opened up an issue on the bot to support leading keywords, but it's not implemented yet.

Both 'tasks' and 'request tasks' had the same description of 'Request
Tasks'. This change gives tasks a distinct description of simply
'Tasks'.

https://bugzilla.redhat.com/show_bug.cgi?id=1232924
@imtayadeway imtayadeway force-pushed the bz-1232924/correct-tasks-description branch from 9f15959 to aab8a90 Compare June 22, 2015 16:29
@imtayadeway
Copy link
Contributor Author

@Fryguy done!

@miq-bot
Copy link
Member

miq-bot commented Jun 22, 2015

Checked commit imtayadeway@aab8a90 with rubocop 0.32.0
0 files checked, 0 offenses detected
Everything looks good. 🍰

@imtayadeway
Copy link
Contributor Author

@abellotti any comments?

@abellotti
Copy link
Member

LGTM. merging.

abellotti added a commit that referenced this pull request Jun 23, 2015
@abellotti abellotti merged commit f648a57 into ManageIQ:master Jun 23, 2015
@chessbyte chessbyte added this to the Sprint 26 Ending July 13, 2015 milestone Jun 23, 2015
@imtayadeway imtayadeway deleted the bz-1232924/correct-tasks-description branch July 6, 2015 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants