Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The labels on the catalog item and catalog bundle service entry point… #3348

Merged
merged 2 commits into from Jul 6, 2015
Merged

The labels on the catalog item and catalog bundle service entry point… #3348

merged 2 commits into from Jul 6, 2015

Conversation

lgalis
Copy link
Contributor

@lgalis lgalis commented Jul 3, 2015

The labels on the catalog item and catalog bundle service entry points changed to add 'State Machine':

Updated labels:
Provisioning Entry Point
State Machine (NS/Cls/Inst)
Reconfigure Entry Point
State Machine (NS/Cls/Inst)
Retirement Entry Point
State Machine (NS/Cls/Inst)

https://bugzilla.redhat.com/show_bug.cgi?id=1238819

1238899_after_display
1238899_after_edit
1238899_before_display
1238899_before_edit

@lgalis
The labels on the catalog item and catalog bundle service entry point…
4ac5e03 
…s changed to add "State Machine"

Updated labels:
  Provisioning Entry Point
 State Machine (NS/Cls/Inst)
  Reconfigure Entry Point
 State Machine (NS/Cls/Inst)
  Retirement Entry Point
 State Machine (NS/Cls/Inst)

  https://bugzilla.redhat.com/show_bug.cgi?id=1238819
@h-kataria
Copy link
Contributor

@lgalis you don't need to modify .pot and .po files those are being done by rake task.

@lgalis
The labels on the catalog item and catalog bundle service entry point…
e82fcf9 
…s changed to add "State Machine"

Updated labels:
  Provisioning Entry Point
 State Machine (NS/Cls/Inst)
  Reconfigure Entry Point
 State Machine (NS/Cls/Inst)
  Retirement Entry Point
 State Machine (NS/Cls/Inst)

  https://bugzilla.redhat.com/show_bug.cgi?id=1238819
@lgalis
Copy link
Contributor Author

lgalis commented Jul 6, 2015

@h-kataria
Removed the changes to .po and .pot files

@miq-bot
Copy link
Member

miq-bot commented Jul 6, 2015

Checked commits lgalis@4ac5e03 .. lgalis@e82fcf9 with rubocop 0.32.0
2 files checked, 3 offenses detected

vmdb/app/views/catalog/_form_basic_info.html.haml

  • 🔴 Warn - Line 66, Col - - The = symbol should have one space separating it from code
  • 🔴 Warn - Line 88, Col - - The = symbol should have one space separating it from code
  • 🔴 Warn - Line 110, Col - - The = symbol should have one space separating it from code

Fryguy added a commit that referenced this pull request Jul 6, 2015
@Fryguy
Merge pull request #3348 from lgalis/modified_labels_for_service_entr…
535f4ed 
…y_points

The labels on the catalog item and catalog bundle service entry point…
@Fryguy Fryguy merged commit 535f4ed into ManageIQ:master Jul 6, 2015
@Fryguy Fryguy added this to the Sprint 26 Ending July 13, 2015 milestone Jul 6, 2015
@lgalis lgalis deleted the modified_labels_for_service_entry_points branch August 3, 2015 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement lifecycle/services ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lgalis @h-kataria @miq-bot @Fryguy