Custom buttons not visible in second row #3365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chessbyte
changed the title
|
@lgalis Please rebase and re-push. |
When having multiple VM custom button groups that would casue them to be displayed on the next line, they are not visible until the window is resized. This change modifies the height for the cell in the layout to allow for the initial display. https://bugzilla.redhat.com/show_bug.cgi?id=1234987
When having multiple VM custom button groups that would cause them to be displayed on the next line, they are not visible until the window is resized. Modify the function that adjusts the height of the taskbar as needed so that the custom buttons in the second row are visible . https://bugzilla.redhat.com/show_bug.cgi?id=1234987
lgalis
force-pushed
the
custom_butons_not_visible_in_second_row
branch
from
20121a9
to
c50dd69
Compare
|
Checked commits lgalis@b568c8e .. lgalis@c50dd69 with rubocop 0.32.0 |
|
Verified fix. |
dclarizio
pushed a commit
that referenced
this pull request
Jul 9, 2015
…ond_row Custom buttons not visible in second row
|
@lgalis after merging this PR i'm getting error:
|
|
Fixed in #3422 |
dclarizio
pushed a commit
that referenced
this pull request
Jul 13, 2015
…arcell Custom button fix for #3365 …
tenderlove
added a commit
to tenderlove/manageiq
that referenced
this pull request
Jul 13, 2015
* master: (37 commits) fix border color around a required select box. Fixed typo in .codeclimate.yml Added classes to list of CLASSES_THAT_PARTICIPATE_IN_RBAC providerForemanFormController - add $scope.model pointing to the real model checkchange.js - use lodash for deep copy and deep compare, check that modelCopy exists Add .codeclimate.yml Custom button fix for ManageIQ#3365 causes js exception in non-explorer tabs add lodash.js kubernetes: persist env section in container definition Changed tooltip text when Adding new VM Policy Make PidFile#pid return nil for non-numeric pid file contents Unable to add Infrastructure and cloud providers Set available locales on all threads. Fixed code to use local variable instead of @record. Increase connection pool to 5. Switch webserver from thin to puma. Angular version upgrade to 1.3.15 Give the blocked connection some time to notice Remove threadsafe Stack class for sqlserver support back in 2008. convert style1 class tables to form-horizontal class layout Issue: ManageIQ#3139 ...
tenderlove
added a commit
to tenderlove/manageiq
that referenced
this pull request
Jul 13, 2015
* master: fix border color around a required select box. Fixed typo in .codeclimate.yml Added classes to list of CLASSES_THAT_PARTICIPATE_IN_RBAC providerForemanFormController - add $scope.model pointing to the real model checkchange.js - use lodash for deep copy and deep compare, check that modelCopy exists Custom button fix for ManageIQ#3365 causes js exception in non-explorer tabs add lodash.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dclarizio - please review
When having multiple VM custom button groups that would cause them to be displayed on the next line, they are not visible until the window is resized.
This change modifies the height for the cell in the layout to allow for the initial display.
https://bugzilla.redhat.com/show_bug.cgi?id=1234987