[WIP] numeric report charts

[martinpovolny]

Work towards numeric report charts...

https://bugzilla.redhat.com/show_bug.cgi?id=1213294

[martinpovolny]

[miq-bot]

<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush.

[martinpovolny]

Flash version:

[dclarizio]

Status update . . . trying to get some new field value based charts working, but will need to discuss with @martinpovolny to move forward. Marking as WIP until then.

[dclarizio]

@martinpovolny Tested my simple Number of CPUs per provider report chart and found the following:

As noted prior, changing the Chart mode pull down to Counts, should not show the Data column pull down

Data column pull down should only show the columns available as Summary Calculation Rows

In the shot below, I'm thinking we should show "Number of CPUs - Average" and "Number of CPUs - Total" as choices for the Data Column. Whichever is chosen is what is used for the chart.

Running the report results in the following chart showing

This may be due to another bug where the actual report summary lines aren't being shown (also the same in master, guess I need to file a bug). There should be a Total summary line for each provider with the count value. If we had Average and Total checked, we should see 2 lines per provider. There is also an "All Rows" line at the bottom of the report, but it has no values showing either.

[dclarizio]

@martinpovolny opened related issue #3738 which MAY be causing the charts to not have the proper data.

[martinpovolny]

@dclarizio : I hacked in the simple usecase to make sure I understand what you want for that one.

on "As noted prior, changing the Chart mode pull down to Counts, should not show the Data column pull down" -- sure, will do that just want to make sure I have the general idea prior to playing with these small things...

on "Data column pull down should only show the columns available as Summary Calculation Rows"

ok, the fields will be limited to the ones that are used for sorting in the Summary page.

But: on the aggregations: see app/helpers/report_helper.rb -- I see no sense in showing the aggregation function "Total" or "Average" in simplest usecase, because we have no groups and run no aggregations over no groups.

If you try the more complex usecase (see the examples in the specs/... in this PR) you would run through the else branch in app/helpers/report_helper.rb and you would have the selection of the aggregate functions that are calculated over the groups.

But in the simple usecase you would have just one number as total or average, and it makes no sense to me to chart just one value.

I'll modify the form to match your feedback regarding selection of fieds and hiding of the row column and get back to you.

[dclarizio]

@martinpovolny ping me to discuss the summary based use case when you get a chance.

[miq-bot]

<gemfile_checker />Gemfile changes detected in commits martinpovolny@3e3acdf .. martinpovolny@76ac795. /cc @JPrause @simaishi

[miq-bot]

Checked commits martinpovolny@3e3acdf .. martinpovolny@d211fa3 with rubocop 0.32.1 and haml-lint 0.13.0
7 files checked, 27 offenses detected

app/controllers/report_controller/reports/editor.rb

• 🔶 - Line 673, Col 36 - Style/SpaceAroundOperators - Operator ||= should be surrounded with a single space.
• 🔶 - Line 674, Col 36 - Style/SpaceAroundOperators - Operator ||= should be surrounded with a single space.

lib/report_formatter/chart_common.rb

• 🔶 - Line 435, Col 18 - Style/MultilineOperationIndentation - Align the operands of an expression in an assignment spanning multiple lines.
• 🔶 - Line 506, Col 21 - Style/SpaceAroundOperators - Operator ? should be surrounded with a single space.
• 🔹 - Line 356, Col 5 - Metrics/AbcSize - Assignment Branch Condition size for build_reporting_chart_dim2_numeric is too high. [69.83/15]
• 🔹 - Line 356, Col 5 - Metrics/CyclomaticComplexity - Cyclomatic complexity for build_reporting_chart_dim2_numeric is too high. [7/6]
• 🔹 - Line 356, Col 5 - Metrics/MethodLength - Method has too many lines. [38/25]
• 🔹 - Line 418, Col 5 - Metrics/AbcSize - Assignment Branch Condition size for build_reporting_chart_other_numeric is too high. [46.84/15]

lib/report_formatter/jqplot.rb

• 🔹 - Line 85, Col 5 - Metrics/AbcSize - Assignment Branch Condition size for axis_category_labels_ticks is too high. [25.2/15]
• 🔹 - Line 90, Col 121 - Metrics/LineLength - Line is too long. [124/120]
• 🔹 - Line 138, Col 5 - Metrics/AbcSize - Assignment Branch Condition size for build_reporting_chart_other_numeric is too high. [27.17/15]
• 🔹 - Line 161, Col 5 - Metrics/AbcSize - Assignment Branch Condition size for build_reporting_chart_dim2_numeric is too high. [22.2/15]

spec/lib/report_formater/jqplot_formater_spec.rb

• 🔴 Warn - Line 20, Col 49 - Lint/UselessAssignment - Useless assignment to variable - host.
• 🔶 - Line 22, Col 9 - Style/LeadingCommentSpace - Missing space after #.
• 🔶 - Line 33, Col 9 - Style/LeadingCommentSpace - Missing space after #.
• 🔶 - Line 35, Col 9 - Style/LeadingCommentSpace - Missing space after #.
• 🔶 - Line 36, Col 9 - Style/LeadingCommentSpace - Missing space after #.
• 🔶 - Line 37, Col 9 - Style/LeadingCommentSpace - Missing space after #.
• 🔶 - Line 39, Col 9 - Style/LeadingCommentSpace - Missing space after #.
• 🔶 - Line 50, Col 9 - Style/LeadingCommentSpace - Missing space after #.
• 🔶 - Line 51, Col 9 - Style/LeadingCommentSpace - Missing space after #.
• 🔹 - Line 32, Col 121 - Metrics/LineLength - Line is too long. [127/120]
• 🔹 - Line 70, Col 121 - Metrics/LineLength - Line is too long. [128/120]
• 🔹 - Line 79, Col 121 - Metrics/LineLength - Line is too long. [121/120]
• 🔹 - Line 101, Col 121 - Metrics/LineLength - Line is too long. [122/120]
• 🔹 - Line 102, Col 121 - Metrics/LineLength - Line is too long. [128/120]
• 🔹 - Line 105, Col 121 - Metrics/LineLength - Line is too long. [128/120]