Dispense with temp file generation in inventory collection on Windows #3653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit https://github.com/djberg96/manageiq/commit/4bd8ffc9e08908970daab7aa2618815989b34ce4 with rubocop 0.32.1 and haml-lint 0.13.0 |
|
👍 @bronaghs @blomquisg Please review. |
|
@djberg96 Nice find!!!! I reviewed the code and it looks good to me! 👍 |
blomquisg
added a commit
that referenced
this pull request
Jul 29, 2015
Dispense with temp file generation in inventory collection on Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change modifies the powershell inventory collection script so that it's no longer writing XML to a temp file, but instead just writes directly to stdout. The WinRM library is just gathering stdout information, so writing to a temp file was not only not necessary, but reading it back out was time consuming.
With this change I saw a 30-40% speed improvement.