Corrects problem calling show_link with bad value #4324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@petrblaho : Thx for the fix. Can you, please, provide a simple test here? Just check that for given ID the page renders the partial and sends a 200. Just post/get Thx! |
petrblaho
force-pushed
the
show_link_record_id_correction
branch
from
d53ca75
to
5732df4
Compare
show_link method assumes its first parameter to be ActiveRecord instance - it calls .id on it. When show_link method was introduced in 52458a6 @record.id was used as it was used to generate url for link before. This patch corrects that. Without it MIQ generates error when user is trying to view page like /ems_infra/show/1?display=timeline
petrblaho
force-pushed
the
show_link_record_id_correction
branch
from
5732df4
to
aa73af2
Compare
|
Checked commit petrblaho@aa73af2 with ruby 1.9.3, rubocop 0.33.0, and haml-lint 0.13.0 |
dclarizio
pushed a commit
that referenced
this pull request
Sep 21, 2015
Corrects problem calling show_link with bad value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
show_link method assumes its first parameter to be ActiveRecord instance
When show_link method was introduced in
52458a6
@record.id was used as it was used to generate url for link before.
This patch corrects that. Without it MIQ generates error when user is
trying to view page like /ems_infra/show/1?display=timeline