Automate | Services | Changed CatalogItemInitialization automate method for Orchestration provisioning. #4416
Conversation
fields to the Orchestration provision item when used with a bundle. CatalogBundleInitialization/CatalogItemInitialization methods were designed to work with VM provisioning, before Orchestration provisioning was introduced. These methods were designed to assist in passing parameters from a bundle service down to individual VM provision tasks. Orchestration provisioning uses a different configuration of tasks to perform provisioning which is not supported by the current methods. https://bugzilla.redhat.com/show_bug.cgi?id=1260436
|
@gmcculloug, @mkanoor |
|
cc @bzwei |
|
|
||
| def destination_key_name(key) | ||
| key.to_s.starts_with?("dialog_") ? key.to_s : "dialog_#{key}" | ||
| end |
There was a problem hiding this comment.
@tinaafitz To support something like a password key with syntax password::dialog_var1 this logic needs to be updated. What do you think of this?
def destination_key_name(key)
key = key.to_s
return key if key.include?("::") || key.starts_with?("dialog_")
"dialog_#{key}"
endThere was a problem hiding this comment.
@gmcculloug
That looks good, I'll make the change.
The orchestration side will have to modified to look for the password format, correct?
There was a problem hiding this comment.
No, the field gets set in the destination (in this case service object) the same as it would if it was just a catalog item being ordered directly. But it would be useful if @bzwei could validate this as well.
|
Checked commits tinaafitz/manageiq@1c94f4b~...ef947e9 with ruby 1.9.3, rubocop 0.33.0, and haml-lint 0.13.0 |
Automate | Services | Changed CatalogItemInitialization automate method for Orchestration provisioning.
Changed CatalogItemInitialization automate method to pass dialog
fields to the Orchestration provision item when used with a bundle.
CatalogBundleInitialization/CatalogItemInitialization methods were
designed to work with VM provisioning, before Orchestration provisioning
was introduced. These methods were designed to assist in passing
parameters from a bundle service down to individual VM provision tasks.
Orchestration provisioning uses a different configuration of tasks to
perform provisioning which is not supported by the current methods.
https://bugzilla.redhat.com/show_bug.cgi?id=1260436