Change watermark timeframe to 3 months/add region #5237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@imtayadeway We also need to add "region" as a column on the report. |
|
@gtanzillo Just added. Can you check especially column / sort by / group by order? |
imtayadeway
force-pushed
the
reporting/fix-watermark-performance-timeframe
branch
from
ba7604b
to
96cc935
Compare
|
(showing the region description) |
|
@gtanzillo made the discussed changes and added a screenshot showing one of the new reports. Can you rereview? |
imtayadeway
changed the title
|
Checked commits imtayadeway/manageiq@4077764~...96cc935 with ruby 1.9.3, rubocop 0.34.2, and haml-lint 0.13.0 |
|
Looks good! 👍 |
gtanzillo
added a commit
that referenced
this pull request
Nov 3, 2015
…formance-timeframe Change watermark timeframe to 3 months/add region
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1276692
After:
/cc @gtanzillo