Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Retire Toolbar from Cloud Provider Instances list page #5557

Merged

Conversation

lgalis
Copy link
Contributor

@lgalis lgalis commented Nov 20, 2015

@lgalis
Copy link
Contributor Author

lgalis commented Nov 20, 2015

@miq-bot add_label ui, bug, wip

will add rspecs

@lgalis lgalis force-pushed the retirement_button_from_cloud_instance_broken branch from b620e12 to 84746b9 Compare November 23, 2015 20:02
@lgalis lgalis changed the title [WIP] Fix for Retire Toolbar from Cloud Provider Instances list page Fix for Retire Toolbar from Cloud Provider Instances list page Nov 23, 2015
@lgalis
Copy link
Contributor Author

lgalis commented Nov 23, 2015

@miq-bot remove_label wip

@miq-bot miq-bot removed the wip label Nov 23, 2015
@lgalis
Copy link
Contributor Author

lgalis commented Nov 23, 2015

@h-kataria , please review

@lgalis lgalis force-pushed the retirement_button_from_cloud_instance_broken branch 2 times, most recently from d683442 to 8024bb2 Compare November 23, 2015 21:56
@lgalis lgalis changed the title Fix for Retire Toolbar from Cloud Provider Instances list page [WIP]Fix for Retire Toolbar from Cloud Provider Instances list page Dec 3, 2015
@lgalis
Copy link
Contributor Author

lgalis commented Dec 3, 2015

@miq-bot add_label wip

the retirement date value is not displayed correctly when re-edited

@miq-bot miq-bot added the wip label Dec 3, 2015
@lgalis lgalis force-pushed the retirement_button_from_cloud_instance_broken branch from 8024bb2 to 1cc385c Compare December 3, 2015 22:02
@miq-bot
Copy link
Member

miq-bot commented Dec 3, 2015

Checked commits lgalis/manageiq@e3fc3ab~...1cc385c with ruby 2.2.3, rubocop 0.34.2, and haml-lint 0.13.0
2 files checked, 1 offense detected

spec/controllers/ems_common_controller_spec.rb

@lgalis lgalis changed the title [WIP]Fix for Retire Toolbar from Cloud Provider Instances list page Fix for Retire Toolbar from Cloud Provider Instances list page Dec 4, 2015
@lgalis
Copy link
Contributor Author

lgalis commented Dec 4, 2015

@miq-bot remove_label wip

@miq-bot miq-bot removed the wip label Dec 4, 2015
@h-kataria h-kataria added this to the Sprint 33 Ending Dec 7, 2015 milestone Dec 4, 2015
@h-kataria
Copy link
Contributor

verified fix

h-kataria added a commit that referenced this pull request Dec 4, 2015
…tance_broken

Fix for Retire Toolbar from Cloud Provider Instances list page
@h-kataria h-kataria merged commit 1aae3e5 into ManageIQ:master Dec 4, 2015
@lgalis lgalis deleted the retirement_button_from_cloud_instance_broken branch December 4, 2015 19:26
chrisarcand pushed a commit to chrisarcand/manageiq that referenced this pull request Dec 18, 2015
…to '5.5.z'


5.5.z retirement button from cloud instances broken

5.5.z BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1291342
Clean cherry pick from: ManageIQ#5557

See merge request !618
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants