Display MIQ/Red Hat Automate domain current/available version in the UI.

[h-kataria]

Added changes to Display MIQ/Red Hat Automate domain current/available versions in the UI if they both don't match.

https://bugzilla.redhat.com/show_bug.cgi?id=1283037

@mkanoor @gmcculloug please review, This PR should be merged after #5548 is merged..

[gmcculloug]

@h-kataria My understanding was this message would be displayed when you first enter Automate -> Explorer and the root "Datastore" element is selected in the tree and would contain a flash message for each domain that was out-of-sync.

With the current approach the user needs to click on the domain before seeing the message.

[gmcculloug]

This message should be displayed for all datastores at the same time so it will need to include the domain name. Maybe something like this: "%s domain: Current version - %s, Available version - %s"

Example: ManageIQ domain: Current version - 5.3, Available version - 5.4

[h-kataria]

@gmcculloug this message in only displayed when user has selected MIQ or Red Hat domain in the tree, message is not displayed on any other node so i am not sure if showing a Domain name is needed.

[h-kataria]

@gmcculloug about your other comment about showing this message on Datastore node, i had initially thought that it should only be displayed on Root node of Automate explorer tree, but model methods that are added are instance methods, @mkanoor suggested to add message on Domain level, i can rework these changes if model method can be changed to return version info for all domains in an array.

[gmcculloug]

There should be one method that gets passed the domain and checks the version information and returns either nil or the message string. The message that contains the domain name can be used in both places. (No need to maintain two different strings for this.)

Something like this:

  def add_all_domains_version_message(domains)
    @version_messages = domains.collect do |domain|
      domain_version_message(domain)
    end.compact
  end

  def domain_version_message(domain)
    version = domain.version
    available_version = domain.available_version
    return if version.nil? || available_version.nil?
    return if version != available_version

    _("Currently running %s version, you have %s version available.") % [version, available_version]
  end

Then above where you currently call add_domain_version_message you would do this:
@version_message = domain_version_message(@record) if @record.domain?

[mkanoor]

@gmcculloug @h-kataria
I think we should have the messages at the domain as well as the datastore level.

[h-kataria]

@gmcculloug added messages on Datastore node as well, please review.

[mkanoor]

@h-kataria
👍
The only comment I have is there was to be some way of indicating in the UI that the domain is out of sync similar to how we show disabled domains.

[h-kataria]

@mkanoor i think we can check with UX team after this release to see if they have better ideas of representing such nodes in the tree, rather than adding * or striking out special nodes in the tree, we already have nodes grayed out and striked out and now adding an * in the tree might be too much.

[gmcculloug]

The visible_domains variable does not server any purpose here, just pass @grid_data into the add_all_domains_version_message method.

[h-kataria]

@mkanoor @gmcculloug addressed your comments, please re-review

screenshots:

[gmcculloug]

👍

[miq-bot]

Checked commit h-kataria@46bfa05 with ruby 1.9.3, rubocop 0.34.2, and haml-lint 0.13.0
1 file checked, 1 offense detected

app/controllers/miq_ae_class_controller.rb

• 🔹 - Line 206, Col 121 - Metrics/LineLength - Line is too long. [142/120]

[gmcculloug]

@Fryguy This PR is saying that travis is pending but clicking through shows travis completed successfully. Any thoughts?

[Fryguy]

@gmcculloug I'm not really sure. If you notice the coverage also fell by a lot, which implies that one of the suites didn't "finish" properly. I'm wondering if we should just kick off the whole thing again.