Do not fill mountpoint of empty disk #5677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disks are not really created and mounted. The mounpoint is used for comparing with attached volumes, so by storing empty disks we are showing the relation badly. The mountpoint is mandatory column so we cannot store disks without it. Fixes BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1287635
Ladas
force-pushed
the
openstack_dont_fill_mountpoint_of_0_size_disks
branch
from
01e26cc
to
1b304f0
Compare
|
Checked commit Ladas@1b304f0 with ruby 2.2.3, rubocop 0.34.2, and haml-lint 0.13.0 app/models/manageiq/providers/openstack/cloud_manager/refresh_parser.rb
|
|
@blomquisg please review |
blomquisg
added a commit
that referenced
this pull request
Dec 8, 2015
…_0_size_disks Do not fill mountpoint of empty disk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disks are not really created an mounted, we just want to show
them as blank.
The mounpoint is used for comparing with attached volumes, so
it was showing the relation badly.
Fixes BZ:
https://bugzilla.redhat.com/show_bug.cgi?id=1287635