Editing a catalog item no longer fails in a bad way #5784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label bug |
|
@miq-bot add_label provisioning |
syncrou
force-pushed
the
edit_catalog_item_fails
branch
from
5a827aa
to
d5e6dae
Compare
|
@gmcculloug please review |
| @@ -299,4 +302,57 @@ | |||
| expect(request.options[:owner_group]).to eq(owner.current_group.description) | |||
| end | |||
| end | |||
|
|
|||
| context "#respool_to_folder" do | |||
| before(:each) do | |||
There was a problem hiding this comment.
@syncrou Please change these to before do to match the rest of the spec.
https://bugzilla.redhat.com/show_bug.cgi?id=1236966 Editing a catalog item will no longer fail with an error If a resource pool or ems folder is removed from an existing catalog item.
syncrou
force-pushed
the
edit_catalog_item_fails
branch
from
d5e6dae
to
5d05116
Compare
|
@gmcculloug - Updated with your requests. Please review. |
|
Checked commit syncrou@5d05116 with ruby 2.2.3, rubocop 0.34.2, and haml-lint 0.13.0 |
gmcculloug
added a commit
that referenced
this pull request
Dec 15, 2015
Editing a catalog item no longer fails in a bad way
chrisarcand
pushed a commit
to chrisarcand/manageiq
that referenced
this pull request
Dec 18, 2015
Editing a catalog item no longer fails in a bad way https://bugzilla.redhat.com/show_bug.cgi?id=1290215 Editing a catalog item will no longer fail with an error If a resource pool or ems folder is removed from an existing catalog item. Upstream BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1236966 PR: ManageIQ#5784 Cherry-pick was clean See merge request !625
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1236966
Editing a catalog item will no longer fail with an error
If a resource pool or ems folder is removed from an
existing catalog item.